@EresDev

So if we need to deploy both static files and cloudflare pages functions we need the following github artifact structure:

github_artifact_folder
    static_html_files
        index.html
    functions

If we need to deploy only static files we need the following github artifact structure:

github_artifact_folder
    index.html

Correct? If so could you add this info to the README file for future reference.

Correct? If so could you add this info to the README file for future reference.

You are right.

However, a better approach came into my mind today and I have re-done this today.

What was the issue with my previous submission? It worked, but it was not as clean as the new solution. output_directory parameter was being used for two different purposes. One, to extract artifact into. Second, to use it as static directory name. It was okay if the entire directory was static, but now it is confusing when we have backend functions and whole output_directory is not a static directory. The new solution introduces a new parameter statics_directory to decouple both. It also offers an opportunity to move all old and new projects to the same directory structure, while still supporting old directory structure.

I have added the info to readme, and I have also updated the QA links.
@rndquu

@EresDev doesn't seem to work anymore. Should not have to rely on a pull request. Should deploy on every commit.

https://github.com/ubiquity/pay.ubq.fi/actions/runs/9562570163/job/26359224909

I can leave it for another day or two for testing in production but otherwise will need to revert.

Please prioritize this as it affects all of our projects. Thanks.

@EresDev doesn't seem to work anymore. Should not have to rely on a pull request. Should deploy on every commit.

I didn't change the trigger. So whatever the trigger (commit or pull) was set before this PR, it should work. But let me take a look, maybe it is breaking somewhere.

If needed, please work on the development branch directly. It might help you debug faster.

We can revert if you can't figure it out in the next day or two.

Please prioritize this as it affects all of our projects. Thanks.

Ok, it appears there is no issue. It is working fine.
https://github.com/ubiquity/pay.ubq.fi/actions/runs/9564115180/job/26364104059

We need to understand a tricky part to know why it failed in your case.
development branch uses artifact name: static
beta branch uses artifact name: full-stack-app

In your link, the "deploy to cloudflare" workflow was on development branch. It needed an artifact created by "build" workflow on the same branch. But the previous run of "build" workflow was "beta" branch.

If "build" workflow runs before "deploy to cloudflare" there is no issue. You probably ran "deploy to cloudflare" manually, and last "build" was done by the different branch with a different artifact name.

So, until we have gift-cards in beta branch, to build and deploy manually, first run the build workflow, and then run the deploy to cloudflare workflow.

I have also run the deploy workflow on work.ubq.fi just to be safe, and it also worked fine. https://github.com/ubiquity/work.ubq.fi/actions/runs/9477343124/job/26363140008

Please prioritize this as it affects all of our projects. Thanks.

Ok, it appears there is no issue. It is working fine. https://github.com/ubiquity/pay.ubq.fi/actions/runs/9564115180/job/26364104059

We need to understand a tricky part to know why it failed in your case. development branch uses artifact name: static beta branch uses artifact name: full-stack-app

In your link, the "deploy to cloudflare" workflow was on development branch. It needed an artifact created by "build" workflow on the same branch. But the previous run of "build" workflow was "beta" branch.

If "build" workflow runs before "deploy to cloudflare" there is no issue. You probably ran "deploy to cloudflare" manually, and last "build" was done by the different branch with a different artifact name.

So, until we have gift-cards in beta branch, to build and deploy manually, first run the build workflow, and then run the deploy to cloudflare workflow.

I have also run the deploy workflow on work.ubq.fi just to be safe, and it also worked fine. https://github.com/ubiquity/work.ubq.fi/actions/runs/9477343124/job/26363140008

The above info is correct if we want to deploy to development branch. The deploy of non-default branch still doesn't work. I am looking into it.
All other projects should deploy correctly despite this. Only the gift-cards PR has issues.

Deployment of branch beta pay.ubq.fi successfull: https://github.com/ubiquity/pay.ubq.fi/actions/runs/9568299929/job/26378171356

Deployment of branch development pay.ubq.fi successfull: https://github.com/ubiquity/pay.ubq.fi/actions/runs/9567051444/job/26377832050

Deployment of work.ubq.fi successfull: https://github.com/ubiquity/work.ubq.fi/actions/runs/9568407358

It is all working fine now. @0x4007

beta.pay.ubq.fi and pay.ubq.fi resolve to the same commit @rndquu

http://alpha.beta.pay.ubq.fi/ (a made up one now for testing improperly config'd dynamic settings) does not resolve.

beta.pay.ubq.fi and pay.ubq.fi resolve to the same commit @rndquu

http://alpha.beta.pay.ubq.fi/ (a made up one now for testing improperly config'd dynamic settings) does not resolve.

ubiquity/pay.ubq.fi#226 (comment)